Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43897 )
Change subject: soc/intel/tigerlake: Simplify if-statements ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43897/2/src/soc/intel/tigerlake/rom... File src/soc/intel/tigerlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/43897/2/src/soc/intel/tigerlake/rom... PS2, Line 25: m_cfg->InternalGfx = is_dev_enabled(dev); : if (m_cfg->InternalGfx) { : /* Set IGD stolen size to 60MB. */ : m_cfg->IgdDvmt50PreAlloc = 0xFE; : } else { : m_cfg->IgdDvmt50PreAlloc = 0; : } : What about this? m_cfg->IgdDvmt50PreAlloc = m_cfg->InternalGfx ? 0xFE : 0;