Hello Philipp Deppenwiese, build bot (Jenkins), Patrick Georgi, Martin Roth, Matt DeVillier, Jeremy Soller, Christian Walter, Arthur Heymans, Marcello Sylvester Bauer,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/40520
to look at the new patch set (#4).
Change subject: [RFC]drivers/smmstore: Implement SMMSTORE version 2 ......................................................................
[RFC]drivers/smmstore: Implement SMMSTORE version 2
The SMMSTORE version 2 is a complete redesign of the current driver.
Some key features: * Uses a fixed communication buffer instead writing to arbitrary ring0 memory addresses * Gives the caller full control over the used data format * Splits the store into smaller chunks to allow fault tolerant updates * Don't provide feedback about the actual read/written bytes * Return an error if the requested operation would overflow the communication buffer
Seperates the SMMSTORE into 64KiB blocks that can individually be read/written/erased. To be used by payloads that implement a FaultTolerant Variable store like Tianocore.
The implementation has been tested against EDK2 master.
An example EDK2 implementation can be found here: https://github.com/9elements/edk2-1/commit/7c5f0f6bee86dd0a94251b82f0e6f3a10...
Change-Id: I25e49d184135710f3e6dd1ad3bed95de950fe057 Signed-off-by: Patrick Rudolph patrick.rudolph@9elements.com --- M Documentation/drivers/index.md A Documentation/drivers/smmstorev2.md M payloads/libpayload/include/coreboot_tables.h M src/commonlib/include/commonlib/cbmem_id.h M src/commonlib/include/commonlib/coreboot_tables.h M src/drivers/smmstore/Kconfig M src/drivers/smmstore/Makefile.inc A src/drivers/smmstore/ramstage.c M src/drivers/smmstore/smi.c M src/drivers/smmstore/store.c M src/include/smmstore.h M src/lib/coreboot_table.c 12 files changed, 638 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/20/40520/4