Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33417 )
Change subject: soc/intel: Add function to set DPR ......................................................................
Patch Set 7:
(4 comments)
https://review.coreboot.org/c/coreboot/+/33417/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/33417/2//COMMIT_MSG@11 PS2, Line 11:
Tested how?
Done
https://review.coreboot.org/c/coreboot/+/33417/2/src/soc/intel/common/block/... File src/soc/intel/common/block/systemagent/systemagent_early.c:
https://review.coreboot.org/c/coreboot/+/33417/2/src/soc/intel/common/block/... PS2, Line 235: u32
uint32_t
Done
https://review.coreboot.org/c/coreboot/+/33417/2/src/soc/intel/common/block/... PS2, Line 238: report
reporting?
Done
https://review.coreboot.org/c/coreboot/+/33417/7/src/soc/intel/fsp_broadwell... File src/soc/intel/fsp_broadwell_de/ramstage.c:
https://review.coreboot.org/c/coreboot/+/33417/7/src/soc/intel/fsp_broadwell... PS7, Line 31: #include <soc/broadwell_de.h>
<intelblocks/systemagent.h> […]
<intelblocks/systemagent.h> can't be used on fsp_broadwell_de due to conflicts with soc specific headers. It's not related to the CPU but northbridge, so defining it in cpu/intel/ seems wrong either. Please propose a better solution.