Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46406 )
Change subject: mb/google/asurada: Implement regulator control for vdd2, vddq and vmddr ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... File src/mainboard/google/asurada/regulator.c:
https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... PS5, Line 17:
static int get_mt6360_regulator_id(enum mtk_regulator regulator) […]
DRAM regulators are controlled by mt6360(EC side) and MT6359(AP side) on MT8192. Each PMIC has its own regulator ID definition. Such remapping may not easy to apply when using multiple PMICs.
https://review.coreboot.org/c/coreboot/+/46406/5/src/mainboard/google/asurad... PS5, Line 24: MTK_REGULATOR_VDD1: : break;
do nothing?
controlled by mt6359p