Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47190 )
Change subject: mb/purism/librem_mini: Drop community comments in GPIO config
......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47190/1/src/mainboard/purism/librem...
File src/mainboard/purism/librem_cnl/variants/librem_mini/gpio.c:
https://review.coreboot.org/c/coreboot/+/47190/1/src/mainboard/purism/librem...
PS1, Line 231: /* DW0: 0x44000300, DW1: 0x00000000 */
the macros were generated by intelp2m, I spot checked the output but didn't verify each and every pa […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47190
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ieecc9bd67d020e141c3a1f1d387034df5e563068
Gerrit-Change-Number: 47190
Gerrit-PatchSet: 3
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 04 Nov 2020 21:22:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Michael Niewöhner
foss@mniewoehner.de
Gerrit-MessageType: comment