Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Patrick Rudolph, EricR Lai, Karthik Ramasubramanian.
Sumeet R Pawnikar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57035 )
Change subject: soc/intel/alderlake: set power limits dynamically for thermal
......................................................................
Patch Set 8:
(4 comments)
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/57035/comment/e7b97bfb_e97c00e7
PS7, Line 35: ADL_P_282_15W = 15,
ex TDP_15W=15 then you can use in […]
Done
File src/soc/intel/alderlake/chip.h:
https://review.coreboot.org/c/coreboot/+/57035/comment/8a5368e7_99aba206
PS6, Line 34: enum soc_intel_alderlake_cpu_tdps {
if the value are the same, you can just declare 9W 15W 28W 45W. […]
Ack
File src/soc/intel/alderlake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/57035/comment/fb3986d4_d3a4fcbf
PS4, Line 80: switch (sa_pci_id) {
That works 😊
Done
File src/soc/intel/alderlake/systemagent.c:
https://review.coreboot.org/c/coreboot/+/57035/comment/e381d982_92858872
PS7, Line 81: if (sa_pci_id == cpuid_to_adlp[i].cpu_id) {
you can use && here as well
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57035
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic331a3debb076ef08a312a31edc1468974fd4902
Gerrit-Change-Number: 57035
Gerrit-PatchSet: 8
Gerrit-Owner: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Wed, 01 Sep 2021 13:33:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-MessageType: comment