Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46234 )
Change subject: mb/google/volteer: Drop GPIO_MEM_CONFIG macros
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46234/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/46234/3//COMMIT_MSG@9
PS3, Line 9: Allow memory strap GPIOs to be sourced from variant gpio.h.
: This is done to fix compilation issue of macro redefinition
: when one of the variant uses a different set of memory strap
: GPIOs.
nit: reflow for 72 chars
Done
https://review.coreboot.org/c/coreboot/+/46234/3/src/mainboard/google/voltee...
File src/mainboard/google/volteer/variants/halvor/include/variant/gpio.h:
https://review.coreboot.org/c/coreboot/+/46234/3/src/mainboard/google/voltee...
PS3, Line 13: #define GPIO_MEM_CONFIG_0 GPP_C12
: #define GPIO_MEM_CONFIG_1 GPP_C15
: #define GPIO_MEM_CONFIG_2 GPP_C14
: #define GPIO_MEM_CONFIG_3 GPP_D15
+1 what Furquan said
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46234
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5c1ebfb39b2a56ca94a92941e8beed1acc28e655
Gerrit-Change-Number: 46234
Gerrit-PatchSet: 6
Gerrit-Owner: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Fagerburg
pfagerburg@chromium.org
Gerrit-Reviewer: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 14 Oct 2020 06:05:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Gerrit-MessageType: comment