Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39816 )
Change subject: src: Remove not used 'include <smbios.h>'
......................................................................
Patch Set 9:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39816/7/src/include/device/device.h
File src/include/device/device.h:
PS7:
I will, but changes on device/device.h must be merged before removing smbios. […]
Ok, that's where the confusion started. I missed that patch set 1 already
changed `device/device.h`. So we never saw the errors if it isn't changed,
and hence nobody could fix/understand them. I'll rebase the current version
on master to see the errors, please bear with me.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39816
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I12345a5b6c9ce94ca9f8b555154b2278a8ff97bf
Gerrit-Change-Number: 39816
Gerrit-PatchSet: 9
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 10 Apr 2020 17:39:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-MessageType: comment