Attention is currently required from: Amanda Hwang, Dtrain Hsu, Paul Menzel, Pranava Y N, Subrata Banik.
Ian Feng has posted comments on this change by Ian Feng. ( https://review.coreboot.org/c/coreboot/+/85037?usp=email )
Change subject: mb/google/fatcat/var/francka: Update gpio settings ......................................................................
Patch Set 8:
(7 comments)
File src/mainboard/google/fatcat/Kconfig:
https://review.coreboot.org/c/coreboot/+/85037/comment/836cf226_5b870911?usp... : PS6, Line 71: select BOARD_GOOGLE_BASEBOARD_FATCAT
Maybe mention this too in the commit message.
Done
File src/mainboard/google/fatcat/variants/francka/gpio.c:
https://review.coreboot.org/c/coreboot/+/85037/comment/eb765b59_33929e2d?usp... : PS6, Line 62: ISH_GP_1_SNSR_HDR
Please modify the pin name.
Done
https://review.coreboot.org/c/coreboot/+/85037/comment/7d7c02b6_3919063d?usp... : PS6, Line 62: ISH_GP_1_SNSR_HDR
Please modify the pin name.
Done
https://review.coreboot.org/c/coreboot/+/85037/comment/35229b98_45c73ffe?usp... : PS6, Line 219: used_R
Should it delete _R?
Done
https://review.coreboot.org/c/coreboot/+/85037/comment/146313cf_17eba20e?usp... : PS6, Line 219: used_R
Should it delete _R?
Done
https://review.coreboot.org/c/coreboot/+/85037/comment/1509d8f9_c0f7e4ee?usp... : PS6, Line 390: /* GPP_V13: GPP_V13_CATERR_N */ : PAD_CFG_NF(GPP_V13, NONE, DEEP, NF1), : /* GPP_V14: GPP_V14_FORCEPR_N */ : PAD_CFG_NF(GPP_V14, NONE, DEEP, NF1), : /* GPP_V15: GPP_V15_THERMTRIP_N */ : PAD_CFG_NF(GPP_V15, NONE, DEEP, NF1),
Please check settings with EE, I didn't see the settings in the GPIO table.
Done
https://review.coreboot.org/c/coreboot/+/85037/comment/7463c2df_87f919b4?usp... : PS6, Line 390: /* GPP_V13: GPP_V13_CATERR_N */ : PAD_CFG_NF(GPP_V13, NONE, DEEP, NF1), : /* GPP_V14: GPP_V14_FORCEPR_N */ : PAD_CFG_NF(GPP_V14, NONE, DEEP, NF1), : /* GPP_V15: GPP_V15_THERMTRIP_N */ : PAD_CFG_NF(GPP_V15, NONE, DEEP, NF1),
Please check settings with EE, I didn't see the settings in the GPIO table.
Done