Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47584 )
Change subject: soc/amd: factor out vbnv_cmos_failed() into soc/amd/common/vboot
......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47584/2/src/soc/amd/common/block/vb...
File src/soc/amd/common/block/vbnv_cmos/Kconfig:
https://review.coreboot.org/c/coreboot/+/47584/2/src/soc/amd/common/block/vb...
PS2, Line 1: SOC_AMD_COMMON_BLOCK_VBNV_CMOS
Thanks Furquan, I'd wondered about the "Block" name. I guess I thought of it similarly to Felix.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/47584
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7f976c6c5a2a715e1a5372bb93fe657d0d86c848
Gerrit-Change-Number: 47584
Gerrit-PatchSet: 4
Gerrit-Owner: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 20 Nov 2020 19:29:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Martin Roth
martinroth@google.com
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de
Gerrit-MessageType: comment