Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45847 )
Change subject: soc/intel/xeon_sp: Add get_system_memory_map()
......................................................................
Patch Set 5: Code-Review-2
It looks like the new check on the memory hob fails on TiogaPass but doesn't on DeltaLake. Looking into the failure before we commit.
In get_system_memory_map(void)
/* assert the pointer to the hob is not NULL */
fail: assert(*memmap_addr != NULL);
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45847
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I54675b52aaf2999d884b3c20ccb143fbbf8b138a
Gerrit-Change-Number: 45847
Gerrit-PatchSet: 5
Gerrit-Owner: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 06 Oct 2020 17:34:33 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment