Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44302 )
Change subject: mb/lenovo/thinkcentre_m91p add ThinkCentre M91p
......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44302/12/src/mainboard/lenovo/think...
File src/mainboard/lenovo/thinkcentre_m91p/Kconfig:
https://review.coreboot.org/c/coreboot/+/44302/12/src/mainboard/lenovo/think...
PS12, Line 25: config DRAM_RESET_GATE_GPIO # FIXME: check this
: int
: default 10
This is wrong. There's no reset gate on this board, you can use GPIO72 instead. But please leave a comment:
# Board has no DRAM reset gate GPIO, and GPIO72 is unused.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44302
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I48bf9093099abdece3b52d7169c000e25b400feb
Gerrit-Change-Number: 44302
Gerrit-PatchSet: 12
Gerrit-Owner: Name of user not set #1003058
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sun, 09 Aug 2020 10:19:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment