Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34080 )
Change subject: mb/google/octopus: Add custom SAR values for Bluebird
......................................................................
Patch Set 7: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34080/7/src/mainboard/google/octopu...
File src/mainboard/google/octopus/variants/casta/mainboard.c:
PS7:
nit: The general rule seems to be to name this file as variant.c (see bloog/variant.c)
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34080
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I107a8519832fcf906b94f958a3dc508d19bb4727
Gerrit-Change-Number: 34080
Gerrit-PatchSet: 7
Gerrit-Owner: shkim
sh_.kim@samsung.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Seunghwan Kim
sh_.kim@samsung.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: shkim
sh_.kim@samsung.com
Gerrit-CC: Kevin Chiu
Kevin.Chiu@quantatw.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Comment-Date: Wed, 10 Jul 2019 00:47:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment