[coreboot-gerrit] Change in coreboot[master]: sconfig: Allow chipset to provide a base devicetree

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44037 )

Change subject: sconfig: Allow chipset to provide a base devicetree
......................................................................

Patch Set 9:

(1 comment)

https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/main.c 
File util/sconfig/main.c:

https://review.coreboot.org/c/coreboot/+/44037/9/util/sconfig/main.c@713 
PS9, Line 713: base_root_dev
> An alias added in override tree isn't getting caught as a duplicate so it just ends up getting assigned to the first one silently.

Aah it is because `new_device()`, `find_alias()` uses base_root_dev always. That should really be root_parent because that holds the pointer to current parent under which devices are being added. So, `new_device()` should check for alias conflict within the current tree and then `override_devicetree()` should check for alias conflict within the primary tree.
> since adding a device reference in an override doesn't really make sense in the first place.

We might need that if devices are added/defined only in the overridetree and also referenced there?