Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/72713 )
Change subject: util/amdfwtool: add comment about reused PSP firmware type 0x5f ......................................................................
util/amdfwtool: add comment about reused PSP firmware type 0x5f
On family 15h and 16h processors with PSP, the PSP firmware type 0x5f corresponds to AMD_FW_PSP_SMUSCS, while on family 17h and 19h this corresponds to AMD_FW_TPMLITE. Add comments to those two enum values to clarify this.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: Ia5c125ec6a0eb548f58a457f9040278391d2101c Reviewed-on: https://review.coreboot.org/c/coreboot/+/72713 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Bao Zheng fishbaozi@gmail.com Reviewed-by: Fred Reitberger reitbergerfred@gmail.com --- M util/amdfwtool/amdfwtool.h 1 file changed, 21 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Bao Zheng: Looks good to me, but someone else must approve Fred Reitberger: Looks good to me, approved
diff --git a/util/amdfwtool/amdfwtool.h b/util/amdfwtool/amdfwtool.h index d3d6866..f30dce6 100644 --- a/util/amdfwtool/amdfwtool.h +++ b/util/amdfwtool/amdfwtool.h @@ -68,8 +68,8 @@ AMD_FW_MSMU = 0x5a, AMD_FW_SPIROM_CFG = 0x5c, AMD_FW_MPIO = 0x5d, - AMD_FW_TPMLITE = 0x5f, - AMD_FW_PSP_SMUSCS = 0x5f, + AMD_FW_TPMLITE = 0x5f, /* family 17h & 19h */ + AMD_FW_PSP_SMUSCS = 0x5f, /* family 15h & 16h */ AMD_FW_DMCUB = 0x71, AMD_FW_PSP_BOOTLOADER_AB = 0x73, AMD_RIB = 0x76,