[coreboot-gerrit] Change in coreboot[master]: mb/google/dedede: Add memory initialization support for dedede

[Karthik Ramasubramanian (Code Review)]

Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39136 )

Change subject: mb/google/dedede: Add memory initialization support for dedede
......................................................................

Patch Set 21:

(1 comment)

https://review.coreboot.org/c/coreboot/+/39136/18/src/mainboard/google/deded... 
File src/mainboard/google/dedede/variants/waddledoo/Makefile.inc:

https://review.coreboot.org/c/coreboot/+/39136/18/src/mainboard/google/deded... 
PS18, Line 16: empty
> Furquan, we're reading gpio straps from board and directly using that as index for spd instead of ha […]

As Meera mentioned, ID0 is used for Hynix, ID1 is used for Micron and ID is used for Samsung.

Furquan, I am not sure if you want to put all the SPDs now itself or do you want to add them as and when they become available.

FYI, Pre-proto SMT2 build might have it fixed based on the feature based SPD IDs instead of vendor based SPD IDs.