Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39599 )
Change subject: nb/intel/sandybridge: Tidy up code and comments ......................................................................
Patch Set 6:
(9 comments)
https://review.coreboot.org/c/coreboot/+/39599/4/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/gma.c:
https://review.coreboot.org/c/coreboot/+/39599/4/src/northbridge/intel/sandy... PS4, Line 722:
i'd still use tabs and not spaces here
Tabs look muuuch worse.
https://review.coreboot.org/c/coreboot/+/39599/4/src/northbridge/intel/sandy... PS4, Line 743:
tabs
They make the right hand side of the expressions fly away, though.
https://review.coreboot.org/c/coreboot/+/39599/4/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/northbridge.c:
https://review.coreboot.org/c/coreboot/+/39599/4/src/northbridge/intel/sandy... PS4, Line 259:
tabs?
Tabs look muuuch worse.
https://review.coreboot.org/c/coreboot/+/39599/4/src/northbridge/intel/sandy... PS4, Line 455:
tabs?
Tabs look muuuch worse.
https://review.coreboot.org/c/coreboot/+/39599/4/src/northbridge/intel/sandy... PS4, Line 471:
tabs?
Tabs look muuuch worse.
https://review.coreboot.org/c/coreboot/+/39599/4/src/northbridge/intel/sandy... PS4, Line 477:
tabs?
Tabs look muuuch worse.
https://review.coreboot.org/c/coreboot/+/39599/2/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_common.c:
https://review.coreboot.org/c/coreboot/+/39599/2/src/northbridge/intel/sandy... PS2, Line 3309: =
i find it slightly odd. i'd drop just the 0 and put the | at the ends of the last lines. […]
Done
https://review.coreboot.org/c/coreboot/+/39599/2/src/northbridge/intel/sandy... File src/northbridge/intel/sandybridge/raminit_ivy.c:
https://review.coreboot.org/c/coreboot/+/39599/2/src/northbridge/intel/sandy... PS2, Line 51: tREFI = 7.8usec
not sure, but this might be some information that should be kept as comment?
Done
https://review.coreboot.org/c/coreboot/+/39599/2/src/northbridge/intel/sandy... PS2, Line 79: tXS-offset: tXS = tRFC+10ns
same?
Done