Attention is currently required from: Jonathan Zhang, TimLiu-SMCI, Johnny Lin, David Hendricks, Christian Walter, Angel Pons, Shuming Chu (Shuming), Arthur Heymans.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72617 )
Change subject: soc/intel/xeon_sp/uncore.c: Add CXL memory into memory map
......................................................................
Patch Set 7:
(1 comment)
File src/soc/intel/xeon_sp/uncore.c:
https://review.coreboot.org/c/coreboot/+/72617/comment/918125e8_6329c8b0
PS7, Line 241: #if CONFIG(SOC_INTEL_HAS_CXL)
Can this not be a regular if instead of preprocessor #if?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/72617
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If3f856958a3e6ed3909240ee455bb639e487087f
Gerrit-Change-Number: 72617
Gerrit-PatchSet: 7
Gerrit-Owner: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: David Hendricks
david.hendricks@gmail.com
Gerrit-Reviewer: Jian-Ming Wang
jianmingW@supermicro.com
Gerrit-Reviewer: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Reviewer: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Reviewer: Simon Chou
simonchou@supermicro.com.tw
Gerrit-Reviewer: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-CC: Tim Chu
Tim.Chu@quantatw.com
Gerrit-Attention: Jonathan Zhang
jon.zhixiong.zhang@gmail.com
Gerrit-Attention: TimLiu-SMCI
timliu@supermicro.com.tw
Gerrit-Attention: Johnny Lin
Johnny_Lin@wiwynn.com
Gerrit-Attention: David Hendricks
david.hendricks@gmail.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Shuming Chu (Shuming)
s1218944@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Comment-Date: Sun, 05 Mar 2023 16:08:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment