Evan Green has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39581 )
Change subject: src/soc/intel/jasperlake: Update SD card ACPI device ......................................................................
Patch Set 2:
(3 comments)
This change is ready for review.
https://review.coreboot.org/c/coreboot/+/39581/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/39581/1//COMMIT_MSG@11 PS1, Line 11: signal in _PS0/_PS3 methods.
Please re-flow for 75 characters.
Done
https://review.coreboot.org/c/coreboot/+/39581/1/src/soc/intel/tigerlake/acp... File src/soc/intel/tigerlake/acpi/scs.asl:
https://review.coreboot.org/c/coreboot/+/39581/1/src/soc/intel/tigerlake/acp... PS1, Line 99: /* _DSM x86 Device Specific Method
Done
https://review.coreboot.org/c/coreboot/+/39581/1/src/soc/intel/tigerlake/inc... File src/soc/intel/tigerlake/include/soc/gpio_soc_defs_jsl.h:
https://review.coreboot.org/c/coreboot/+/39581/1/src/soc/intel/tigerlake/inc... PS1, Line 40: #define SD_PWR_EN_PIN GPP_H1
Align?
Done