[coreboot-gerrit] Change in coreboot[master]: drivers/wifi: Check device is of type PCI before checking vendor ID

[Furquan Shaikh (Code Review)]

Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47364 )

Change subject: drivers/wifi: Check device is of type PCI before checking vendor ID
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/c/coreboot/+/47364/1/src/drivers/wifi/generic/ac... 
File src/drivers/wifi/generic/acpi.c:

https://review.coreboot.org/c/coreboot/+/47364/1/src/drivers/wifi/generic/ac... 
PS1, Line 215: 	if (CONFIG(USE_SAR))
> How about move the check, here?

I don't think it would make much difference. I kept it inside `emit_sar_acpi_structures()` to make the code in this function easier to read. To be honest, I think either ways its fine. Unless you feel very strongly about it, I think we can keep the check in `emit_sar_acpi_structures()`.