Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32789 )
Change subject: soc/intel/icelake: Make use of gpio_pm_configure() ......................................................................
Patch Set 7:
(2 comments)
https://review.coreboot.org/#/c/32789/6/src/soc/intel/icelake/chip.c File src/soc/intel/icelake/chip.c:
https://review.coreboot.org/#/c/32789/6/src/soc/intel/icelake/chip.c@142 PS6, Line 142: TODO(subrata): Need to implement 4us IRQ width recommendation.
Done
Sorry, I meant this is very specific to google boards. Boards might have other reasons to not enable the GPIO PM programming. I don't think we should get rid of this call. That is another reason why we should add the gpio_override_pm config. Not all mainboards have to change this and we can use the default value of enabling all PM programming bits if no override set in mainboard.
https://review.coreboot.org/#/c/32789/7/src/soc/intel/icelake/chip.c File src/soc/intel/icelake/chip.c:
https://review.coreboot.org/#/c/32789/7/src/soc/intel/icelake/chip.c@121 PS7, Line 121: !value[i] Its easy to miss the print in the huge set of logs printed during boot. How about this: 1. Add another config gpio_override_pm that can be set by the mainboards that want to override the default GPIO PM config. 2. Boards that set gpio_override_pm are expected to set gpio_pm[] for all communities. 3. In this function, you can check if gpio_override_pm is set. If yes, then memcpy gpio_pm[] to value[]. Else memset 0x3F(its macro) to value[].