Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38728 )
Change subject: cpu/x86: Cache stages for RESET_VECTOR_IN_RAM
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/38728/1/src/cpu/x86/mtrr/nonxip_cac...
File src/cpu/x86/mtrr/nonxip_cache.c:
https://review.coreboot.org/c/coreboot/+/38728/1/src/cpu/x86/mtrr/nonxip_cac...
PS1, Line 65: MTRR_TYPE_WRBACK
Is this not pretty much the same as in cpu/x86/mtrr/xip_cache.c except for having no upper limit for size and also the type of the MTRR? Could the code be made common?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38728
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I57caccceac8550efe33f7273d279275cd6af6a68
Gerrit-Change-Number: 38728
Gerrit-PatchSet: 1
Gerrit-Owner: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Marshall Dawson
marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 06 Apr 2020 07:30:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment