Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45139 )
Change subject: pci_ids: Add ADL IPU PCI IDs ......................................................................
Patch Set 1: Code-Review+2
(3 comments)
https://review.coreboot.org/c/coreboot/+/45139/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45139/1//COMMIT_MSG@7 PS1, Line 7: ADL nit: I would use `Alder Lake` here
https://review.coreboot.org/c/coreboot/+/45139/1//COMMIT_MSG@9 PS1, Line 9: Add PCI IDs for Intel's Image Processing Unit (IPU) for ADL nit: missing period at the end
https://review.coreboot.org/c/coreboot/+/45139/1/src/soc/intel/common/block/... File src/soc/intel/common/block/ipu/ipu.c:
https://review.coreboot.org/c/coreboot/+/45139/1/src/soc/intel/common/block/... PS1, Line 17: PCI_DEVICE_ID_INTEL_ADL_IPU, Please mention this change in the commit message