build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31504 )
Change subject: util/inteltool: Refactor code of GPIOs ......................................................................
Patch Set 9:
(149 comments)
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h File util/inteltool/gpio_baytrail.h:
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@103 PS9, Line 103: "GPIO_S0_SC[000]", "SATA_GP[0]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@104 PS9, Line 104: "GPIO_S0_SC[001]", "SATA_GP[1]", "SATA_DEVSLP[0]", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@105 PS9, Line 105: "GPIO_S0_SC[002]", "SATA_LED#", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@106 PS9, Line 106: "GPIO_S0_SC[003]", "PCIE_CLKREQ[0]#", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@107 PS9, Line 107: "GPIO_S0_SC[004]", "PCIE_CLKREQ[1]#", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@108 PS9, Line 108: "GPIO_S0_SC[005]", "PCIE_CLKREQ[2]#", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@109 PS9, Line 109: "GPIO_S0_SC[006]", "PCIE_CLKREQ[3]#", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@110 PS9, Line 110: "GPIO_S0_SC[007]", "RESERVED", "SD3_WP", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@111 PS9, Line 111: "GPIO_S0_SC[008]", "I2S0_CLK", "HDA_RST#", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@112 PS9, Line 112: "GPIO_S0_SC[009]", "I2S0_FRM", "HDA_SYNC", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@113 PS9, Line 113: "GPIO_S0_SC[010]", "I2S0_DATAOUT", "HDA_CLK", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@114 PS9, Line 114: "GPIO_S0_SC[011]", "I2S0_DATAIN", "HDA_SDO", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@115 PS9, Line 115: "GPIO_S0_SC[012]", "I2S1_CLK", "HDA_SDI[0]", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@116 PS9, Line 116: "GPIO_S0_SC[013]", "I2S1_FRM", "HDA_SDI[1]", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@117 PS9, Line 117: "GPIO_S0_SC[014]", "I2S1_DATAOUT", "RESERVED", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@118 PS9, Line 118: "GPIO_S0_SC[015]", "I2S1_DATAIN", "RESERVED", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@119 PS9, Line 119: "GPIO_S0_SC[016]", "MMC1_CLK", "-", "MMC1_45_CLK", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@120 PS9, Line 120: "GPIO_S0_SC[017]", "MMC1_D[0]", "-", "MMC1_45_D[0]", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@121 PS9, Line 121: "GPIO_S0_SC[018]", "MMC1_D[1]", "-", "MMC1_45_D[1]", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@122 PS9, Line 122: "GPIO_S0_SC[019]", "MMC1_D[2]", "-", "MMC1_45_D[2]", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@123 PS9, Line 123: "GPIO_S0_SC[020]", "MMC1_D[3]", "-", "MMC1_45_D[3]", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@124 PS9, Line 124: "GPIO_S0_SC[021]", "MMC1_D[4]", "-", "MMC1_45_D[4]", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@125 PS9, Line 125: "GPIO_S0_SC[022]", "MMC1_D[5]", "-", "MMC1_45_D[5]", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@126 PS9, Line 126: "GPIO_S0_SC[023]", "MMC1_D[6]", "-", "MMC1_45_D[6]", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@127 PS9, Line 127: "GPIO_S0_SC[024]", "MMC1_D[7]", "-", "MMC1_45_D[7]", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@128 PS9, Line 128: "GPIO_S0_SC[025]", "MMC1_CMD", "-", "MMC1_45_CMD", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@129 PS9, Line 129: "GPIO_S0_SC[026]", "MMC1_RST#", "SATA_DEVSLP[0]", "MMC1_45_RST#", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@130 PS9, Line 130: "GPIO_S0_SC[027]", "SD2_CLK", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@131 PS9, Line 131: "GPIO_S0_SC[028]", "SD2_D[0]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@132 PS9, Line 132: "GPIO_S0_SC[029]", "SD2_D[1]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@133 PS9, Line 133: "GPIO_S0_SC[030]", "SD2_D[2]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@134 PS9, Line 134: "GPIO_S0_SC[031]", "SD2_D[3]_CD#", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@135 PS9, Line 135: "GPIO_S0_SC[032]", "SD2_CMD", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@136 PS9, Line 136: "GPIO_S0_SC[033]", "SD3_CLK", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@137 PS9, Line 137: "GPIO_S0_SC[034]", "SD3_D[0]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@138 PS9, Line 138: "GPIO_S0_SC[035]", "SD3_D[1]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@139 PS9, Line 139: "GPIO_S0_SC[036]", "SD3_D[2]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@140 PS9, Line 140: "GPIO_S0_SC[037]", "SD3_D[3]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@141 PS9, Line 141: "GPIO_S0_SC[038]", "SD3_CD#", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@142 PS9, Line 142: "GPIO_S0_SC[039]", "SD3_CMD", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@143 PS9, Line 143: "GPIO_S0_SC[040]", "SD3_1P8EN", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@144 PS9, Line 144: "GPIO_S0_SC[041]", "SD3_PWREN#", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@145 PS9, Line 145: "GPIO_S0_SC[042]", "ILB_LPC_AD[0]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@146 PS9, Line 146: "GPIO_S0_SC[043]", "ILB_LPC_AD[1]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@147 PS9, Line 147: "GPIO_S0_SC[044]", "ILB_LPC_AD[2]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@148 PS9, Line 148: "GPIO_S0_SC[045]", "ILB_LPC_AD[3]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@149 PS9, Line 149: "GPIO_S0_SC[046]", "ILB_LPC_FRAME#", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@150 PS9, Line 150: "GPIO_S0_SC[047]", "ILB_LPC_CLK[0]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@151 PS9, Line 151: "GPIO_S0_SC[048]", "ILB_LPC_CLK[1]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@152 PS9, Line 152: "GPIO_S0_SC[049]", "ILB_LPC_CLKRUN#", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@153 PS9, Line 153: "GPIO_S0_SC[050]", "ILB_LPC_SERIRQ", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@154 PS9, Line 154: "GPIO_S0_SC[051]", "PCU_SMB_DATA", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@155 PS9, Line 155: "GPIO_S0_SC[052]", "PCU_SMB_CLK", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@156 PS9, Line 156: "GPIO_S0_SC[053]", "PCU_SMB_ALERT#", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@157 PS9, Line 157: "GPIO_S0_SC[054]", "ILB_8254_SPKR", "RESERVED", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@158 PS9, Line 158: "GPIO_S0_SC[055]", "RESERVED", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@159 PS9, Line 159: "GPIO_S0_SC[056]", "RESERVED", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@160 PS9, Line 160: "GPIO_S0_SC[057]", "PCU_UART_TXD", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@161 PS9, Line 161: "GPIO_S0_SC[058]", "RESERVED", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@162 PS9, Line 162: "GPIO_S0_SC[059]", "RESERVED", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@163 PS9, Line 163: "GPIO_S0_SC[060]", "RESERVED", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@164 PS9, Line 164: "GPIO_S0_SC[061]", "PCU_UART_RXD", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@165 PS9, Line 165: "GPIO_S0_SC[062]", "LPE_I2S2_CLK", "SATA_DEVSLP[1]", "RESERVED", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@166 PS9, Line 166: "GPIO_S0_SC[063]", "LPE_I2S2_FRM", "RESERVED", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@167 PS9, Line 167: "GPIO_S0_SC[064]", "LPE_I2S2_DATAIN", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@168 PS9, Line 168: "GPIO_S0_SC[065]", "LPE_I2S2_DATAOUT", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@169 PS9, Line 169: "GPIO_S0_SC[066]", "SIO_SPI_CS#", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@170 PS9, Line 170: "GPIO_S0_SC[067]", "SIO_SPI_MISO", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@171 PS9, Line 171: "GPIO_S0_SC[068]", "SIO_SPI_MOSI", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@172 PS9, Line 172: "GPIO_S0_SC[069]", "SIO_SPI_CLK", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@173 PS9, Line 173: "GPIO_S0_SC[070]", "SIO_UART1_RXD", "RESERVED", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@174 PS9, Line 174: "GPIO_S0_SC[071]", "SIO_UART1_TXD", "RESERVED", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@175 PS9, Line 175: "GPIO_S0_SC[072]", "SIO_UART1_RTS#", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@176 PS9, Line 176: "GPIO_S0_SC[073]", "SIO_UART1_CTS#", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@177 PS9, Line 177: "GPIO_S0_SC[074]", "SIO_UART2_RXD", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@178 PS9, Line 178: "GPIO_S0_SC[075]", "SIO_UART2_TXD", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@179 PS9, Line 179: "GPIO_S0_SC[076]", "SIO_UART2_RTS#", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@180 PS9, Line 180: "GPIO_S0_SC[077]", "SIO_UART2_CTS#", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@181 PS9, Line 181: "GPIO_S0_SC[078]", "SIO_I2C0_DATA", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@182 PS9, Line 182: "GPIO_S0_SC[079]", "SIO_I2C0_CLK", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@183 PS9, Line 183: "GPIO_S0_SC[080]", "SIO_I2C1_DATA", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@184 PS9, Line 184: "GPIO_S0_SC[081]", "SIO_I2C1_CLK", "RESERVED", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@185 PS9, Line 185: "GPIO_S0_SC[082]", "SIO_I2C2_DATA", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@186 PS9, Line 186: "GPIO_S0_SC[083]", "SIO_I2C2_CLK", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@187 PS9, Line 187: "GPIO_S0_SC[084]", "SIO_I2C3_DATA", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@188 PS9, Line 188: "GPIO_S0_SC[085]", "SIO_I2C3_CLK", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@189 PS9, Line 189: "GPIO_S0_SC[086]", "SIO_I2C4_DATA", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@190 PS9, Line 190: "GPIO_S0_SC[087]", "SIO_I2C4_CLK", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@191 PS9, Line 191: "GPIO_S0_SC[088]", "SIO_I2C5_DATA", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@192 PS9, Line 192: "GPIO_S0_SC[089]", "SIO_I2C5_CLK", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@193 PS9, Line 193: "GPIO_S0_SC[090]", "SIO_I2C6_DATA", "ILB_NMI", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@194 PS9, Line 194: "GPIO_S0_SC[091]", "SIO_I2C6_CLK", "SD3_WP", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@195 PS9, Line 195: "RESERVED", "GPIO_S0_SC[092]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@196 PS9, Line 196: "RESERVED", "GPIO_S0_SC[093]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@197 PS9, Line 197: "GPIO_S0_SC[094]", "SIO_PWM[0]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@198 PS9, Line 198: "GPIO_S0_SC[095]", "SIO_PWM[1]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@199 PS9, Line 199: "GPIO_S0_SC[096]", "PMC_PLT_CLK[0]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@200 PS9, Line 200: "GPIO_S0_SC[097]", "PMC_PLT_CLK[1]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@201 PS9, Line 201: "GPIO_S0_SC[098]", "PMC_PLT_CLK[2]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@202 PS9, Line 202: "GPIO_S0_SC[099]", "PMC_PLT_CLK[3]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@203 PS9, Line 203: "GPIO_S0_SC[100]", "PMC_PLT_CLK[4]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@204 PS9, Line 204: "GPIO_S0_SC[101]", "PMC_PLT_CLK[5]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@208 PS9, Line 208: "GPIO_S5[00]", "RESERVED", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@209 PS9, Line 209: "GPIO_S5[01]", "RESERVED", "RESERVED", "RESERVED", "-", "-", "PMC_WAKE_PCIE[1]#", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@210 PS9, Line 210: "GPIO_S5[02]", "RESERVED", "RESERVED", "RESERVED", "-", "-", "PMC_WAKE_PCIE[2]#", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@211 PS9, Line 211: "GPIO_S5[03]", "RESERVED", "RESERVED", "RESERVED", "-", "-", "PMC_WAKE_PCIE[3]#", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@212 PS9, Line 212: "GPIO_S5[04]", "RESERVED", "RESERVED", "RESERVED", "-", "-", "RESERVED", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@213 PS9, Line 213: "GPIO_S5[05]", "PMC_SUSCLK[1]", "RESERVED", "RESERVED", "-", "-", "RESERVED", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@214 PS9, Line 214: "GPIO_S5[06]", "PMC_SUSCLK[2]", "RESERVED", "RESERVED", "-", "-", "RESERVED", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@215 PS9, Line 215: "GPIO_S5[07]", "PMC_SUSCLK[3]", "RESERVED", "RESERVED", "-", "-", "RESERVED", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@216 PS9, Line 216: "GPIO_S5[08]", "RESERVED", "RESERVED", "RESERVED", "-", "-", "RESERVED", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@217 PS9, Line 217: "GPIO_S5[09]", "RESERVED", "RESERVED", "RESERVED", "-", "-", "RESERVED", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@218 PS9, Line 218: "GPIO_S5[10]", "RESERVED", "RESERVED", "RESERVED", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@219 PS9, Line 219: "PMC_SUSPWRDNACK", "GPIO_S5[11]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@220 PS9, Line 220: "PMC_SUSCLK[0]", "GPIO_S5[12]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@221 PS9, Line 221: "RESERVED", "GPIO_S5[13]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@222 PS9, Line 222: "RESERVED", "GPIO_S5[14]", "USB_ULPI_RST#","-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@222 PS9, Line 222: "RESERVED", "GPIO_S5[14]", "USB_ULPI_RST#","-", "-", "-", "-", "-", space required after that ',' (ctx:VxV)
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@223 PS9, Line 223: "PMC_WAKE_PCIE[0]#", "GPIO_S5[15]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@224 PS9, Line 224: "PMC_PWRBTN#", "GPIO_S5[16]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@225 PS9, Line 225: "RESERVED", "GPIO_S5[17]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@226 PS9, Line 226: "PMC_SUS_STAT#", "GPIO_S5[18]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@227 PS9, Line 227: "USB_OC[0]#", "GPIO_S5[19]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@228 PS9, Line 228: "USB_OC[1]#", "GPIO_S5[20]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@229 PS9, Line 229: "PCU_SPI_CS[1]#", "GPIO_S5[21]", "-", "-", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@230 PS9, Line 230: "GPIO_S5[22]", "RESERVED", "RESERVED", "RESERVED", "-", "-", "RESERVED", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@231 PS9, Line 231: "GPIO_S5[23]", "RESERVED", "RESERVED", "RESERVED", "-", "-", "RESERVED", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@232 PS9, Line 232: "GPIO_S5[24]", "RESERVED", "RESERVED", "RESERVED", "-", "-", "RESERVED", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@233 PS9, Line 233: "GPIO_S5[25]", "RESERVED", "RESERVED", "RESERVED", "-", "-", "RESERVED", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@234 PS9, Line 234: "GPIO_S5[26]", "RESERVED", "RESERVED", "RESERVED", "-", "-", "RESERVED", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@235 PS9, Line 235: "GPIO_S5[27]", "RESERVED", "RESERVED", "RESERVED", "-", "-", "RESERVED", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@236 PS9, Line 236: "GPIO_S5[28]", "RESERVED", "RESERVED", "RESERVED", "-", "-", "RESERVED", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@237 PS9, Line 237: "GPIO_S5[29]", "RESERVED", "RESERVED", "RESERVED", "-", "-", "RESERVED", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@238 PS9, Line 238: "GPIO_S5[30]", "RESERVED", "RESERVED", "RESERVED", "-", "-", "RESERVED", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@239 PS9, Line 239: "GPIO_S5[31]", "USB_ULPI_CLK", "RESERVED", "RESERVED", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@240 PS9, Line 240: "GPIO_S5[32]", "USB_ULPI_DATA[0]", "RESERVED", "RESERVED", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@241 PS9, Line 241: "GPIO_S5[33]", "USB_ULPI_DATA[1]", "RESERVED", "RESERVED", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@242 PS9, Line 242: "GPIO_S5[34]", "USB_ULPI_DATA[2]", "RESERVED", "RESERVED", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@243 PS9, Line 243: "GPIO_S5[35]", "USB_ULPI_DATA[3]", "RESERVED", "RESERVED", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@244 PS9, Line 244: "GPIO_S5[36]", "USB_ULPI_DATA[4]", "RESERVED", "RESERVED", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@245 PS9, Line 245: "GPIO_S5[37]", "USB_ULPI_DATA[5]", "RESERVED", "RESERVED", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@246 PS9, Line 246: "GPIO_S5[38]", "USB_ULPI_DATA[6]", "RESERVED", "RESERVED", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@247 PS9, Line 247: "GPIO_S5[39]", "USB_ULPI_DATA[7]", "RESERVED", "RESERVED", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@248 PS9, Line 248: "GPIO_S5[40]", "USB_ULPI_DIR", "RESERVED", "RESERVED", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@249 PS9, Line 249: "GPIO_S5[41]", "USB_ULPI_NXT", "RESERVED", "RESERVED", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@250 PS9, Line 250: "GPIO_S5[42]", "USB_ULPI_STP", "RESERVED", "RESERVED", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_baytrail.h@251 PS9, Line 251: "GPIO_S5[43]", "USB_ULPI_REFCLK", "RESERVED", "RESERVED", "-", "-", "-", "-", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_sunrise.h File util/inteltool/gpio_sunrise.h:
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_sunrise.h@33 PS9, Line 33: "GPP_A12", "BM_BUSY#", "ISH_GP6", "SX_EXIT_HOLDOFF#", line over 80 characters
https://review.coreboot.org/#/c/31504/9/util/inteltool/gpio_sunrise.h@67 PS9, Line 67: "GPP_A12", "BM_BUSY#", "ISH_GP6", "SX_EXIT_HOLDOFF#", line over 80 characters