29 Jul
2020
29 Jul
'20
9:19 a.m.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/28950 )
Change subject: lenovo/x230: introduce FHD variant ......................................................................
Patch Set 12: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/28950/12/src/mainboard/lenovo/x230/... File src/mainboard/lenovo/x230/variants/x230_fhd/gpio.c:
PS12: The GPIOs are the same as the regular X230, right? If so, maybe we need to change a few things in order to avoid duplicating the files.
--
To view, visit https://review.coreboot.org/c/coreboot/+/28950
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0355d39a61956792e69bccd5274cfc2749d72bf0
Gerrit-Change-Number: 28950
Gerrit-PatchSet: 12
Gerrit-Owner: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Alexander Couzens lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Kilian Neuner cb@9-r.net
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Peter Lemenkov lemenkov@gmail.com
Gerrit-Reviewer: Richard Slindee
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Felix Singer felixsinger@posteo.net
Gerrit-CC: Aleksei Kharlamov derlafff@ya.ru
Gerrit-CC: Christian Herzog
Gerrit-CC: Holger Levsen holger@layer-acht.org
Gerrit-CC: Matthias Wiedhalm
Gerrit-CC: Pavel Kovalenko su@nitrocaster.me
Gerrit-CC: Sergey Alirzaev zl29ah@gmail.com
Gerrit-CC: Tom Hiller thrilleratplay@gmail.com
Gerrit-CC: Tomasz Jan Góralczyk
Gerrit-CC: clayton craft
Gerrit-Comment-Date: Wed, 29 Jul 2020 07:19:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment