Attention is currently required from: Nick Vaccaro.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57069 )
Change subject: coreboot tables: Add type-c port info to coreboot table
......................................................................
Patch Set 32: Code-Review+2
(2 comments)
File src/commonlib/include/commonlib/cbmem_id.h:
PS31:
This is actually required for coreboot_table.c in this CL.
Ack
File src/mainboard/google/volteer/mainboard.c:
https://review.coreboot.org/c/coreboot/+/57069/comment/f3451f71_3860469d
PS8, Line 99: struct drivers_intel_pmc_mux_conn_config *config = child->chip_info;
: if (config) {
: info[count].usb2_port_number = config->usb2_port_number;
: info[count].usb3_port_number = config->usb3_port_number;
: info[count].sbu_orientation = config->sbu_orientation;
: info[count].data_orientation = config->hsl_orientation;
: count++;
: }
Is the new conn_get_type_c_list() sufficient for that purpose? If not, are there additional checks […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/57069
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ice732be2fa634dbf31ec620552b383c4a5b41451
Gerrit-Change-Number: 57069
Gerrit-PatchSet: 32
Gerrit-Owner: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Comment-Date: Mon, 04 Oct 2021 15:49:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Nick Vaccaro
nvaccaro@google.com
Gerrit-MessageType: comment