23 Dec
2019
23 Dec
'19
3:48 p.m.
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37760 )
Change subject: bootblock: Support normal/fallback mechanism again ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37760/5/src/arch/x86/Makefile.inc File src/arch/x86/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37760/5/src/arch/x86/Makefile.inc@1... PS5, Line 115: bootblock-$(CONFIG_BOOTBLOCK_NORMAL) += bootblock_normal.c What is the difference between 'normal' and 'simple'? It seems to me this new file should be named simple since the Kconfig for normal indicates a cmos flag. Did the names get swapped or is the Kconfig commentary incorrect?
--
To view, visit https://review.coreboot.org/c/coreboot/+/37760
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7395e62f6682f4ef123da10ac125127a57711ec6
Gerrit-Change-Number: 37760
Gerrit-PatchSet: 5
Gerrit-Owner: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Denis 'GNUtoo' Carikli GNUtoo@cyberdimension.org
Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 23 Dec 2019 14:48:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment