Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43085 )
Change subject: mb/supermicro/x9scl: Split IPMI support into a variant ......................................................................
Patch Set 1:
Unless we're going to insist that all devices in the device tree be enabled, there is no need for this; the long timeout doesn't happen when the ipmi driver is present but disabled in the device tree.
Well, the current inconsistent devicetree is holding CB:35086 back for long enough. So it's either
a) variants (this), b) unconditionally selecting IPMI_KCS (CB:41687), or c) removing `chip drivers/ipmi` from the devicetree (for now).
Which would you prefer?
Additionally, I strongly object to different coreboot variants/builds for boards that are supported by a single platform firmware build from the original board vendor, as is the case with the X9SCL/X9SCL-F/X9SCM/X9SCM-F/X9SCL+-F/X9SCM-II-F (and X9SCL+/X9SCM-II if they ever were made).
coreboot code often depends on compile-time decisions. If you want to change that, just do so. But please don't make other people wait for it.