[coreboot-gerrit] Change in coreboot[master]: soc/mediatek/mt8192: add pmif driver

[Yu-Ping Wu (Code Review)]

Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45398 )

Change subject: soc/mediatek/mt8192: add pmif driver
......................................................................

Patch Set 26:

(3 comments)

https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/pmi... 
File src/soc/mediatek/mt8192/pmif_spi.c:

https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/pmi... 
PS7, Line 171: 	};
> No. This part is to do the calibration to find out the correct timing of spi. […]

1. So they are all random numbers?
2. Why is the 0x1B27 pattern different?

https://review.coreboot.org/c/coreboot/+/45398/26/src/soc/mediatek/mt8192/pm... 
File src/soc/mediatek/mt8192/pmif_spi.c:

https://review.coreboot.org/c/coreboot/+/45398/26/src/soc/mediatek/mt8192/pm... 
PS26, Line 176: int
u32?

https://review.coreboot.org/c/coreboot/+/45398/26/src/soc/mediatek/mt8192/pm... 
PS26, Line 206: 30
ARRAY_SIZE(test_data)