[coreboot-gerrit] Change in coreboot[master]: tigerlake mainboards: switch to devtree aliases for PMC MUX connectors

[Tim Wawrzynczak (Code Review)]

Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45878 )

Change subject: tigerlake mainboards: switch to devtree aliases for PMC MUX connectors
......................................................................

Patch Set 4:

(2 comments)

https://review.coreboot.org/c/coreboot/+/45878/4/src/mainboard/google/voltee... 
File src/mainboard/google/volteer/mainboard.c:

https://review.coreboot.org/c/coreboot/+/45878/4/src/mainboard/google/voltee... 
PS4, Line 29: This is an ugly hack
> Yep :(

I do intend to come back and clean it up 🐨 How about `pcidev_path_on_root(PCH_DEVFN_PMC)` ?

https://review.coreboot.org/c/coreboot/+/45878/4/src/mainboard/google/voltee... 
PS4, Line 32: dev_find_matching_device_on_bus(__pci_0_1f_2->link_list,
> Isn't this looking at the wrong child?  […]

Yes, it certainly is, good catch, needs to traverse its grandchildren.