Hello Richard Spiegel, build bot (Jenkins), Martin Roth, Patrick Georgi, Furquan Shaikh,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/32649
to look at the new patch set (#3).
Change subject: soc/amd/common: Create AcpiMmio functionality from stoneyridge ......................................................................
soc/amd/common: Create AcpiMmio functionality from stoneyridge
Move the stoneyridge AcpiMmio code into soc/amd/common.
The SB800 southbridge introduced the MMIO hardware blocks at 0xfed80000 commonly known as AcpiMmio. Implementations beginning with Mullins enable decode in PMx04. Older designs use PMx24 and allow for configuring the base address. Future work may support the older version.
Comparing the documentation for AMD's RRGs and BKDGs, it is evident that the block locations have not been reassigned across products. In some cases, address locations are deprecated and new ones consumed, e.g. the early GPIO blocks were simpler at offset 0x100 and the newer GPIO banks are now at 0x1500, 0x1600, and 0x1700.
Note: Do not infer the definitions within the hardware blocks are consistent across family/model products.
BUG=b:131682806
Change-Id: I083b6339cd29e72289e63c9331a815c46d71600d Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com --- M src/mainboard/google/kahlee/mainboard.c M src/soc/amd/common/block/acpi/halt.c A src/soc/amd/common/block/acpimmio/Kconfig A src/soc/amd/common/block/acpimmio/Makefile.inc A src/soc/amd/common/block/acpimmio/mmio_util.c A src/soc/amd/common/block/include/amdblocks/acpimmio.h A src/soc/amd/common/block/include/amdblocks/acpimmio_map.h M src/soc/amd/stoneyridge/Kconfig M src/soc/amd/stoneyridge/acpi.c M src/soc/amd/stoneyridge/gpio.c M src/soc/amd/stoneyridge/include/soc/iomap.h M src/soc/amd/stoneyridge/include/soc/southbridge.h M src/soc/amd/stoneyridge/lpc.c M src/soc/amd/stoneyridge/pmutil.c M src/soc/amd/stoneyridge/ramtop.c M src/soc/amd/stoneyridge/reset.c M src/soc/amd/stoneyridge/sb_util.c M src/soc/amd/stoneyridge/smbus.c M src/soc/amd/stoneyridge/smi.c M src/soc/amd/stoneyridge/smi_util.c M src/soc/amd/stoneyridge/smihandler.c M src/soc/amd/stoneyridge/southbridge.c M src/soc/amd/stoneyridge/usb.c 23 files changed, 582 insertions(+), 449 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/49/32649/3