Mike Banon has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30987 )
Change subject: mb/asus: Add Asus A88XM-E FM2+ with documentation ......................................................................
Patch Set 50:
(2 comments)
https://review.coreboot.org/c/coreboot/+/30987/47/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/Kconfig:
https://review.coreboot.org/c/coreboot/+/30987/47/src/mainboard/asus/a88xm-e... PS47, Line 55: config BOARD_ASUS_A88XM_E_DDR3_VOLT_VAL
I don't recall, was this ever tested? By tested, I mean all three voltages. 1. […]
Balazs, should we just remove these voltage options?
https://review.coreboot.org/c/coreboot/+/30987/47/src/mainboard/asus/a88xm-e... File src/mainboard/asus/a88xm-e/acpi/cpstate.asl:
https://review.coreboot.org/c/coreboot/+/30987/47/src/mainboard/asus/a88xm-e... PS47, Line 23: DefinitionBlock ("DSDT.AML", "DSDT", 0x01, OEM_ID, ACPI_TABLE_CREATOR, 0x00010001)
Why is this commented out?
Perhaps because F2A85-M code has been also commented out this way. Think it's better to keep this comment at least as an example