Jamie Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37189 )
Change subject: soc/intel/cannonlake: Add IccMax limitation for CML U22
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37189/1/src/soc/intel/cannonlake/vr...
File src/soc/intel/cannonlake/vr_config.c:
https://review.coreboot.org/c/coreboot/+/37189/1/src/soc/intel/cannonlake/vr...
PS1, Line 109: did
can't we check CPUID ? or its same ?
CML v1 U6/U4/U2 have the same CPUID.
So I use Did to identify them.
https://review.coreboot.org/c/coreboot/+/37189/1/src/soc/intel/cannonlake/vr...
PS1, Line 111: printk(BIOS_DEBUG, "VR_CONFIG: IccMax[IA_CORE] has been limited to 35A\n");
ok, Jamie you might want to reduce the log a little bit. the width of this line is 100 now.
Reduce the length to 90.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/37189
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2ae8feee3073884109e0d171511c5ac01064ffd7
Gerrit-Change-Number: 37189
Gerrit-PatchSet: 2
Gerrit-Owner: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Jamie Chen
jamie.chen@intel.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 25 Nov 2019 10:29:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Kane Chen
kane.chen@intel.com
Gerrit-MessageType: comment