Attention is currently required from: Robert Zieba, Raul Rangel, Felix Held. Rob Barnes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61259 )
Change subject: soc/amd/cezanne: Turn off gpp clock request for disabled devices ......................................................................
Patch Set 12:
(5 comments)
File src/soc/amd/cezanne/chip.h:
https://review.coreboot.org/c/coreboot/+/61259/comment/7f9f28c0_028ce628 PS12, Line 15: GPP_CLK_ON, /* GPP clock always on; default */ nit: inconsistent use of tabs and spaces in this enum.
File src/soc/amd/cezanne/fch.c:
https://review.coreboot.org/c/coreboot/+/61259/comment/cf5700a2_84926649 PS12, Line 19: #include <device/device.h> It'd be good to alphabetize the global imports (even though it's not fully alphabetized as is).
https://review.coreboot.org/c/coreboot/+/61259/comment/2a3302b2_02895823 PS12, Line 158: const fsp_dxio_descriptor *dxio_descs = NULL; Move declarations before logic.
https://review.coreboot.org/c/coreboot/+/61259/comment/ee6a3a96_50b372ea PS12, Line 164: if (dxio_descs != NULL) { Is it an error if dxio_descs == NULL?
https://review.coreboot.org/c/coreboot/+/61259/comment/0db3aa6f_60984137 PS12, Line 173: if (clk_req == CLK_DISABLE || clk_req == CLK_ENABLE) nit: clk_req != GPP_CLK_REQ