[coreboot-gerrit] Change in coreboot[master]: soc/intel/cannonlake: Steal no memory for disabled IGD

[Angel Pons (Code Review)]

Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39454 )

Change subject: soc/intel/cannonlake: Steal no memory for disabled IGD
......................................................................

Patch Set 16: Code-Review+2

(4 comments)

Last round, I promise! 😄

https://review.coreboot.org/c/coreboot/+/39454/16//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/39454/16//COMMIT_MSG@12 
PS16, Line 12: panel
panel *power*

https://review.coreboot.org/c/coreboot/+/39454/16//COMMIT_MSG@15 
PS16, Line 15: Also apply a workaround to prevent a crash, see
             : https://github.com/IntelFsp/FSP/issues/49
             : for details.
Maybe word it this way:

Refer to this issue on IntelFSP for details:
     https://github.com/IntelFsp/FSP/issues/49

https://review.coreboot.org/c/coreboot/+/39454/13/src/soc/intel/cannonlake/r... 
File src/soc/intel/cannonlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/39454/13/src/soc/intel/cannonlake/r... 
PS13, Line 167: 		tconfig->PanelPowerEnable = 0;
> Done

Oh, it was much easier than I thought. I didn't check where `soc_memory_init_params` was called from

https://review.coreboot.org/c/coreboot/+/39454/16/src/soc/intel/cannonlake/r... 
File src/soc/intel/cannonlake/romstage/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/39454/16/src/soc/intel/cannonlake/r... 
PS16, Line 30: power panel
"panel power" ?