HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39976 )
Change subject: mb/siemens/chili: Add new mainboard
......................................................................
Patch Set 31:
(3 comments)
https://review.coreboot.org/c/coreboot/+/39976/31/src/mainboard/siemens/chil...
File src/mainboard/siemens/chili/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39976/31/src/mainboard/siemens/chil...
PS31, Line 5: <acpi/acpi.h>
maybe not used ?
https://review.coreboot.org/c/coreboot/+/39976/31/src/mainboard/siemens/chil...
PS31, Line 11: e <pc80/mc146818rtc.h>
maybe not used.
please check the other includes
https://review.coreboot.org/c/coreboot/+/39976/31/src/mainboard/siemens/chil...
File src/mainboard/siemens/chili/romstage.c:
https://review.coreboot.org/c/coreboot/+/39976/31/src/mainboard/siemens/chil...
PS31, Line 6: <pc80/mc146818rtc.h>
not used?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39976
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1d3508b615ec877edc8db756e9ad38132b37219c
Gerrit-Change-Number: 39976
Gerrit-PatchSet: 31
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Sebastian Witt
seb.witt@googlemail.com
Gerrit-Comment-Date: Mon, 31 Aug 2020 12:13:51 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
