[coreboot-gerrit] [XS] Change in coreboot[main]: soc/intel/meteorlake: Exclude deprecated upd from FSP2.4 builds

[Subrata Banik (Code Review)]

Attention is currently required from: Andrey Petrov, Appukuttan V K, Dinesh Gehlot, Eran Mitrani, Jakub Czapiga, Kapil Porwal, Ronak Kanabar, Tarun.

Subrata Banik has posted comments on this change by Appukuttan V K. ( https://review.coreboot.org/c/coreboot/+/82699?usp=email )

Change subject: soc/intel/meteorlake: Exclude deprecated upd from FSP2.4 builds
......................................................................

Patch Set 3:

(2 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/82699/comment/415fedd1_4b88ce1a?usp... :
PS3, Line 9: EnableMultiPhaseSiliconInit upd is deprecated and has been
           : removed starting with v2.4 of FSP specification.
are you saying `EnableMultiPhaseSiliconInit` UPD has deprecated because it has been set to 1? (w/ FSP 2.4 spec)

have you captured that in FSP spec

File src/drivers/intel/fsp2_0/silicon_init.c:

https://review.coreboot.org/c/coreboot/+/82699/comment/19f31283_767f7969?usp... :
PS3, Line 80: #if (CONFIG(FSPS_HAS_ARCH_UPD) && !CONFIG(PLATFORM_USES_FSP2_4))
why are we disabling `EnableMultiPhaseSiliconInit` for FSP 2.4 specification?

ideally EnableMultiPhaseSiliconInit is viable since sometime FSP 2.1 spec onwards ?