Attention is currently required from: David Hendricks, Rocky Phagura, Arthur Heymans. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52518 )
Change subject: src/cpu/x86/smm: remove debug message; not thread safe ......................................................................
Patch Set 3:
(5 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/52518/comment/161b5713_b71af88d PS1, Line 9: moves the console init code
No. This patch moves a check for an error condition. […]
Ack
Commit Message:
https://review.coreboot.org/c/coreboot/+/52518/comment/0246c1fe_13df12b2 PS3, Line 16: . one period too many?
File src/cpu/x86/smm/smm_module_handler.c:
https://review.coreboot.org/c/coreboot/+/52518/comment/3be9482a_0a9ffb8e PS1, Line 149: if (cpu > CONFIG_MAX_CPUS) {
Yes, if attempting to print the message doesn't work, we might as well not do it.
Ack
https://review.coreboot.org/c/coreboot/+/52518/comment/17a5d679_d46dfa99 PS1, Line 149: cpu > CONFIG_MAX_CPUS
The `=` in the check was lost. This should be: […]
Ack
https://review.coreboot.org/c/coreboot/+/52518/comment/f32d2e42_37e49a85 PS1, Line 157: console_init();
Do you mean placing the `if (cpu >= CONFIG_MAX_CPUS)` check here? Note that only one thread executes […]
Ack