Nico Huber has posted comments on this change. ( https://review.coreboot.org/29533 )
Change subject: soc/intel/skylake: Drop FSP_CAR options ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/29533/1/src/soc/intel/skylake/Kconfig File src/soc/intel/skylake/Kconfig:
https://review.coreboot.org/#/c/29533/1/src/soc/intel/skylake/Kconfig@105 PS1, Line 105: select SKIP_FSP_CAR
If we want to use FSP_CAR, what is the right config how to set? […]
It's not as easy as toggling a Kconfig. And it's different for FSP1.1 (where we have SKIP_FSP_CAR with the inverse logic) and FSP2.0 (where we have FSP_CAR).
IIRC, for FSP1.1 the linker gives an error about a conflict with code from soc/intel/common/. That would have to be fixed, and then we'd have to remove the `select SKIP_FSP_CAR` here (because you can't over- ride a select at the mainboard level) and find a better solution.
For FSP2.0 there are symbols missing when FSP_CAR is selected. When you provide the missing symbols you could `select FSP_CAR` at the mainboard level.
I'm not a friend of the idea to "select" it at the mainboard level, though. It would take away the option to use the open-source version from the person that configures/compiles coreboot. And that seems to be questionable for an open-source project (what coreboot is about).