Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32226 )
Change subject: commonlib/cbfs: Check for presence of CONFIG() macro
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/32226/1/src/commonlib/cbfs.c
File src/commonlib/cbfs.c:
https://review.coreboot.org/#/c/32226/1/src/commonlib/cbfs.c@28
PS1, Line 28: #if defined(CONFIG)
This is very weird code. Why doesn't it do #ifdef printk instead? Looks like that's really what it wants to do. (Also the #elif/#endif below could really use a comment.)
...but not your fault.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32226
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I7e1b67bc0894ca6f0149039054449656b58bcdd3
Gerrit-Change-Number: 32226
Gerrit-PatchSet: 1
Gerrit-Owner: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 08 Apr 2019 18:07:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment