Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34532 )
Change subject: mediatek/mt8183: Add SAMSUNG 4GB LPDDR4X discrete DDR support ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34532/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34532/2//COMMIT_MSG@11 PS2, Line 11: pass
probably not
Ack
https://review.coreboot.org/c/coreboot/+/34532/2/src/mainboard/google/kukui/... File src/mainboard/google/kukui/sdram_configs.c:
https://review.coreboot.org/c/coreboot/+/34532/2/src/mainboard/google/kukui/... PS2, Line 22: 0]
Hi @MTK, in Kukui RAM ID table this should be 8 instead of 0. […]
Ack