Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42073 )
Change subject: soc/amd/common: Allow runtime mapping of ACPIMMIO banks
......................................................................
Patch Set 12:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42073/9/src/soc/amd/common/block/ac...
File src/soc/amd/common/block/acpimmio/mmio_util.c:
https://review.coreboot.org/c/coreboot/+/42073/9/src/soc/amd/common/block/ac...
PS9, Line 10: uint8_t *const ptr = (void *)(AMD_SB_ACPI_MMIO_ADDR + ACPIMMIO_ ## bank ## _BANK)
cast through uintptr_t
Done
https://review.coreboot.org/c/coreboot/+/42073/10/src/soc/amd/common/block/a...
File src/soc/amd/common/block/acpimmio/mmio_util.c:
https://review.coreboot.org/c/coreboot/+/42073/10/src/soc/amd/common/block/a...
PS10, Line 15: bank
Not a fan of how this reads. […]
I would rather exclude the entire <amdblocks/acpimmio_map.h> with ENV_ARM, propose a solution that works for that too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42073
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8d50de60bb1ea1b3a521ab535a5637c4de8c3559
Gerrit-Change-Number: 42073
Gerrit-PatchSet: 12
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Mike Banon
mikebdp2@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 26 Jun 2020 06:28:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raul Rangel
rrangel@chromium.org
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment