Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34263 )
Change subject: soc/intel/apollolake: Add missing typedef gpio_t
......................................................................
Patch Set 3:
(1 comment)
I don't think any of it would compile if the type was really missing...
https://review.coreboot.org/c/coreboot/+/34263/3/src/soc/intel/apollolake/in...
File src/soc/intel/apollolake/include/soc/gpio.h:
https://review.coreboot.org/c/coreboot/+/34263/3/src/soc/intel/apollolake/in...
PS3, Line 31: #include <intelblocks/gpio.h>/* intelblocks/gpio.h depends on definitions in
defined in here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34263
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1ede5e9ebb6bdcd9f49b8d67ab53d0fddb1a3d24
Gerrit-Change-Number: 34263
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Fri, 12 Jul 2019 17:53:50 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment