[coreboot-gerrit] Change in coreboot[master]: mb/google/drallion: Update IA VR TDC current limit

[Kane Chen (Code Review)]

Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38718 )

Change subject: mb/google/drallion: Update IA VR TDC current limit
......................................................................

Patch Set 3:

(2 comments)

fe

https://review.coreboot.org/c/coreboot/+/38718/3//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/c/coreboot/+/38718/3//COMMIT_MSG@10 
PS3, Line 10: and follow b:148912093#comment1.
> follow power team request.

I guess what you want to say is Dralion HW design is baseline so need to set TDC to 48A for U42, U62?

https://review.coreboot.org/c/coreboot/+/38718/3/src/mainboard/google/dralli... 
File src/mainboard/google/drallion/ramstage.c:

https://review.coreboot.org/c/coreboot/+/38718/3/src/mainboard/google/dralli... 
PS3, Line 42: params->TdcPowerLimit[1] = VR_CFG_TDC(48);
Are you sure TdcEnable is set?
Also, you have plt2 set in dev tree already, why do you still need to set TDC?
Did you observe the current over Dralion HW design?