Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40237 )
Change subject: assert: Use __COUNTER__ instead of tag or line number in dead_code() ......................................................................
Patch Set 1:
If we don't need the line number in the identifier, we can just use a global declaration, right? I've pushed a test, CB:40240.
Oh... yes, I guess that's true. Let's take your patch then.
Huh? must have missed something. Last time I checked the linker didn't spat the line number... at least I was sure two days ago.
This is how it looks for me (using crossgcc):
/home/jwerner/jenkins/util/crossgcc/xgcc/bin/aarch64-elf-ld.bfd: coreboot-builds/GOOGLE_BOB/bootblock/security/vboot/vboot_loader.o: in function `verification_should_run': /home/jwerner/jenkins/src/security/vboot/misc.h:49: undefined reference to `_dead_code_assertion_failed'