If we don't need the line number in the identifier, we can just
use a global declaration, right? I've pushed a test, CB:40240.

Oh... yes, I guess that's true. Let's take your patch then.

Huh? must have missed something. Last time I checked the linker
didn't spat the line number... at least I was sure two days ago.

This is how it looks for me (using crossgcc):

/home/jwerner/jenkins/util/crossgcc/xgcc/bin/aarch64-elf-ld.bfd: coreboot-builds/GOOGLE_BOB/bootblock/security/vboot/vboot_loader.o: in function `verification_should_run':
/home/jwerner/jenkins/src/security/vboot/misc.h:49: undefined reference to `_dead_code_assertion_failed'

View Change

To view, visit change 40237. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia0837365b0f3a0b1ce599e10e95676b9867982e1
Gerrit-Change-Number: 40237
Gerrit-PatchSet: 1
Gerrit-Owner: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Mon, 06 Apr 2020 21:19:38 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment