Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35293 )
Change subject: Add ThinkPad R60 iGPU support. ......................................................................
Patch Set 20:
(6 comments)
Please add Documentation/ as well.
https://review.coreboot.org/c/coreboot/+/35293/20//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35293/20//COMMIT_MSG@7 PS20, Line 7: Add ThinkPad R60 iGPU support. it only adds support for the iGPU?
https://review.coreboot.org/c/coreboot/+/35293/20//COMMIT_MSG@14 PS20, Line 14: c only real names are accepted
https://review.coreboot.org/c/coreboot/+/35293/20/src/mainboard/lenovo/r60/s... File src/mainboard/lenovo/r60/smihandler.c:
https://review.coreboot.org/c/coreboot/+/35293/20/src/mainboard/lenovo/r60/s... PS20, Line 35: ec_set_bit(0x00, 0x05); already done in h8.c
https://review.coreboot.org/c/coreboot/+/35293/20/src/mainboard/lenovo/r60/s... PS20, Line 43: printk(BIOS_DEBUG, fix code style
https://review.coreboot.org/c/coreboot/+/35293/20/src/mainboard/lenovo/r60/s... PS20, Line 141: break; ident
https://review.coreboot.org/c/coreboot/+/35293/20/src/mainboard/lenovo/r60/s... PS20, Line 144: case 0x18: add /* fall-through */