Attention is currently required from: Ravi kumar, Shelley Chen, Julius Werner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49767 )
Change subject: sc7280: aop loading changes ......................................................................
Patch Set 41:
(26 comments)
File src/soc/qualcomm/sc7280/aop_load_reset.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/f37da272_ae0196a1 PS41, Line 11: bool aop_fw_entry; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/3303a355_9b4a2a4b PS41, Line 11: bool aop_fw_entry; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/977b1bfd_0233a22d PS41, Line 13: struct prog aop_fw_prog = code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/58afbcfa_d1183e1c PS41, Line 13: struct prog aop_fw_prog = please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/b3303dfd_cb88b63d PS41, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/fa8e76f5_4ebc31c8 PS41, Line 14: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/aop"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/2eff5360_2282dce9 PS41, Line 16: if (prog_locate(&aop_fw_prog)) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/d9264359_e0d7764e PS41, Line 16: if (prog_locate(&aop_fw_prog)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/9916a800_406d8c1c PS41, Line 17: die("SOC image: AOP_FW not found"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/4bd2f287_2c644cb2 PS41, Line 17: die("SOC image: AOP_FW not found"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/8c406363_c492aff4 PS41, Line 19: aop_fw_entry = selfload(&aop_fw_prog); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/91345ed3_558e2d09 PS41, Line 19: aop_fw_entry = selfload(&aop_fw_prog); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/12847dc4_f297add2 PS41, Line 20: if (!aop_fw_entry) code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/6c98fa81_4ef02553 PS41, Line 20: if (!aop_fw_entry) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/1e485086_df4fb25b PS41, Line 21: die("SOC image: AOP load failed"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/739dab61_5756bb0c PS41, Line 21: die("SOC image: AOP load failed"); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/53e824f1_c462cf7c PS41, Line 23: clock_reset_aop(); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/f57003e0_60c913f4 PS41, Line 23: clock_reset_aop(); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/598262e6_f5dd1599 PS41, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/c51fa011_47aed0d1 PS41, Line 25: printk(BIOS_DEBUG, "\nSOC:AOP brought out of reset.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/mmu.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/ff20f4ab_f65152b5 PS41, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/fc208553_6fcf32e5 PS41, Line 25: mmu_config_range((void *)_aop_code_ram, REGION_SIZE(aop_code_ram), CACHED_RAM); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/94c07665_b5b1c044 PS41, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/2a4a3e1b_55434c47 PS41, Line 26: mmu_config_range((void *)_aop_data_ram, REGION_SIZE(aop_data_ram), CACHED_RAM); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/ad85a0b8_7b2cdc98 PS41, Line 15: REGION_SIZE(dram_aop) / KiB); code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-120300): https://review.coreboot.org/c/coreboot/+/49767/comment/f3345d6c_16c2621c PS41, Line 15: REGION_SIZE(dram_aop) / KiB); please, no spaces at the start of a line