Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39615 )
Change subject: sc7180: Add display hardware pipe line initialization ......................................................................
Patch Set 34: Code-Review+2
(2 comments)
LGTM but this patch order doesn't work, you have to reorder them!
https://review.coreboot.org/c/coreboot/+/39615/25/src/mainboard/google/trogd... File src/mainboard/google/trogdor/Kconfig:
https://review.coreboot.org/c/coreboot/+/39615/25/src/mainboard/google/trogd... PS25, Line 21: select DRIVERS_TI_SN65DSI86BRIDGE
I have moved to correct order in the bridge patch, as the other patch required this change to fix bu […]
Sorry, I don't understand what you mean. If you click on this patch https://review.coreboot.org/c/coreboot/+/42899/13 and you look at the "Relation chain" on the right, you will see that "sc7180: Add display hardware pipe line initialization" comes before "sc7180: Add support for sn65dsi86 bridge" in the list. However, "sc7180: Add display hardware pipe line initialization" calls the sn65dsi86_bridge_init() function which is implemented in "sc7180: Add support for sn65dsi86 bridge". You cannot call a function before it is implemented. Please just flip the order of the two patches around to resolve this build issue, the system won't let me merge it otherwise!
https://review.coreboot.org/c/coreboot/+/39615/32/src/mainboard/google/trogd... File src/mainboard/google/trogdor/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39615/32/src/mainboard/google/trogd... PS32, Line 8: #include "board.h"
done
Ack