Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48467 )
Change subject: soc/intel/xeon_sp: Use native CAR teardown
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/48467/1/src/soc/intel/xeon_sp/cpx/K...
File src/soc/intel/xeon_sp/cpx/Kconfig:
https://review.coreboot.org/c/coreboot/+/48467/1/src/soc/intel/xeon_sp/cpx/K...
PS1, Line 51: bool
Specifying types shouldn't be needed here
What does this do? I don't see it used anywhere.
https://review.coreboot.org/c/coreboot/+/48467/1/src/soc/intel/xeon_sp/cpx/K...
PS1, Line 54: INTEL_CAR_NEM
Shouldn't this be selected?
I think so too.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48467
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I756c2d479fef859a460696300422f08013a300f1
Gerrit-Change-Number: 48467
Gerrit-PatchSet: 1
Gerrit-Owner: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Anjaneya "Reddy" Chagam
anjaneya.chagam@intel.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Marc Jones
marc@marcjonesconsulting.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 16 Dec 2020 15:07:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment